Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands stats to mongodb plugin. #6905

Merged

Conversation

AnastasiyaRagozina
Copy link
Contributor

@AnastasiyaRagozina AnastasiyaRagozina commented Jan 15, 2020

Add commands statistic.
MongoDB doc: metrics.commands

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Comment on lines 94 to 97
"findAndModify_command_total": "FindAndModifyCommandTotal",
"findAndModify_command_failed": "FindAndModifyCommandFailed",
"getMore_command_total": "GetMoreCommandTotal",
"getMore_command_failed": "GetMoreCommandFailed",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you further convert these to snake_case: find_and_modify_command_total

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 92a6e0e3

@danielnelson danielnelson added area/mongodb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Feb 11, 2020
@danielnelson danielnelson added this to the 1.15.0 milestone Mar 23, 2020
@danielnelson danielnelson merged commit 3e1c7a8 into influxdata:master Mar 23, 2020
denispershin added a commit to denispershin/telegraf that referenced this pull request Mar 23, 2020
# Conflicts:
#	plugins/inputs/mongodb/mongodb_data_test.go
denispershin added a commit to denispershin/telegraf that referenced this pull request Mar 23, 2020
denispershin added a commit to denispershin/telegraf that referenced this pull request Mar 23, 2020
denzilribeiro pushed a commit to denzilribeiro/telegraf that referenced this pull request Mar 27, 2020
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
veorlo pushed a commit to GlobalNOC/telegraf that referenced this pull request May 4, 2020
HarshitOnGitHub pushed a commit to HarshitOnGitHub/telegraf that referenced this pull request May 8, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mongodb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants